aws / aws-step-functions-data-science-sdk-python

Step Functions Data Science SDK for building machine learning (ML) workflows and pipelines on AWS
Apache License 2.0
285 stars 87 forks source link

fix: Use unique workflow names for state machine integ tests #148

Closed wong-a closed 3 years ago

wong-a commented 3 years ago

Issue #, if available: N/A

Description of changes:

Concurrent test runs in the same account would fail because test_state_machine_definition.py uses the same hardcoded state machine name in the test cases. This fixes it by generating a unique name using unique_name_from_base from the sagemaker SDK which we are using the the sagemaker integ tests.

Sample error:

tests/integ/test_state_machine_definition.py:72: AssertionError
------------------------------ Captured log call -------------------------------
ERROR    stepfunctions:stepfunctions.py:208 A workflow with the same name already exists on AWS Step Functions. To update a workflow, use Workflow.update().
=========================== short test summary info ============================
FAILED tests/integ/test_state_machine_definition.py::test_task_state_machine_creation

Most of the lines changed in this PR are trailing whitespace removals.

Testing

Ran the test suite:

$ tox -e py38 -- -s -vv tests/integ/test_state_machine_definition.py

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

StepFunctions-Bot commented 3 years ago

AWS CodeBuild CI Report

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository