aws / aws-step-functions-data-science-sdk-python

Step Functions Data Science SDK for building machine learning (ML) workflows and pipelines on AWS
Apache License 2.0
285 stars 87 forks source link

Support placeholders for processing step #155

Closed ca-nguyen closed 3 years ago

ca-nguyen commented 3 years ago

Issue #, if available: #117, #139, #94

Description of changes: Currently, it is not possible to use placeholders for Sagemaker Processor properties . The properties cannot be defined dynamically, as they need to be defined in the Processor which does not accept placeholders. This change makes it possible to use placeholders for Processor properties by using the parameters field that are passed down from the ProcessingStep.

Proposed changes Use the parameters field that is compatible with placeholders to define ProcessingStep properties. Merge the sagemaker generated configs with the input parameters:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

ca-nguyen commented 3 years ago

Thank you both for your review! @wong-a 's solution is less prone to errors and removes the need to map each arg to CreateProcessingJob request location.

This makes for a simpler and more effective solution and makes it the customer's responsibility to use a parameters structure that is up to date with SageMaker documents.

ca-nguyen commented 3 years ago

The summary indicates that this closes #85 but that one doesn't seem to be an issue for processing step. please amend if needed before you merge.

You are right! will remove it from the linked issues!

ca-nguyen commented 3 years ago

Received 2 ship-its - merging PR

StepFunctions-Bot commented 3 years ago

AWS CodeBuild CI Report

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository