search

aws / aws-swf-flow-library

AWS Simple Workflow Flow framework library
Apache License 2.0
61 stars 54 forks source link

[SWF] Implement DecisionTaskPoller.awaitTermination. #6

Open manikandanrs opened 8 years ago

manikandanrs commented 8 years ago

From @zstd on January 15, 2015 13:47

Right now method DecisionTaskPoller.awaitTermination not implemented (there is only TODO item) and WorkflowWorker stops without waiting for currently active polling task to complete.

This may lead to sporadical errors in situation when we stop workflow and start it immediately: in that case stopped workflow may 'steal' decision task from starting workflow without ability to process it - that will cause decision task timeout.

Copied from original issue: aws/aws-sdk-java#346

manikandanrs commented 8 years ago

From @christophercurrie on February 10, 2015 21:52

:+1: for this. Implementing graceful shutdown is very difficult (read: impossible) without a proper lifecycle implementation.

manikandanrs commented 8 years ago

From @zstd on February 11, 2015 6:59

Ок. I have seen the code and understand that if this feature was trivial it was already implemented. Nevertheless, I'd be glad to hear if this improvement was at least planned for 'not-so-near' future.