aws / aws-toolkit-azure-devops

AWS Toolkit for Azure DevOps
Other
245 stars 101 forks source link

Invoke Lambda Function - Synchronous execution failure is not failing vsts release step #175

Open clowtown opened 5 years ago

clowtown commented 5 years ago

Describe the bug Given #137 and #147 causing a lambda execution failure (via cloudwatch logs only), VSTS release step is reporting successful completion of the lambda invocation. To reproduce

  1. Given a lambda to invoke, build release pipeline, etc.
  2. Define a release step (any agent, linux, vs2017 etc)
  3. Add step : AWS Invoke Lambda Function
  4. Provide required info and select Synchronous under Invocation Type
  5. Deploy release

Expected behavior Invoke Lambda release step should fail if the lambda execution fails.

Screenshots

Configuration: image Cloudwatch logs showing lambda invoke failed (AWS level failure, not in my code) image ADO release step showing green/success invocation image

Your Environment

clowtown commented 5 years ago

@hunterwerlla - any updates on this? This seems like a broad impact bug and violates basic expectations of the task with synchronous execution. We've had a lot of false positive ci steps because the task marches on despite the lambda throwing exceptions.

hunterwerlla commented 5 years ago

Looking at the code it seems we don't read the function error field, I agree this should be fixed.

Sayan751 commented 2 years ago

@hunterwerlla Is there any update on this? This is causing too much nasty surprises in our apps.

CheeseNPort commented 2 years ago

Would love to see it fixed, or at least a comment from the developer

AmySchaplowsky commented 6 months ago

I'm running into this issue as well is there any response from the dev on this?

lorax-dmarkham commented 4 months ago

Also running into this issue. Any update?