aws / aws-toolkit-azure-devops

AWS Toolkit for Azure DevOps
Other
243 stars 101 forks source link

Add ability to preserve successfully provisioned resources create by Cloudformation feature added on 30 Aug 2021 #434

Open sboonyakiatACR opened 2 years ago

sboonyakiatACR commented 2 years ago

On 30 Aug 2021 AWS has released an ability to preserve the successfully provisioned resource and only roll back the failed resource. This feature has cut down my troubleshooting time literally in half. Is this something that can be achieved by the AWS Toolkit for Azure DevOps?

bryceitoc9 commented 2 years ago

Hi @sboonyakiatACR

I'm assuming you're talking about Cloudformation's disableRollback? This isn't currently implemented but we can look to add this as a future option.

sboonyakiatACR commented 2 years ago

Hi @sboonyakiatACR

I'm assuming you're talking about Cloudformation's disableRollback? This isn't currently implemented but we can look to add this as a future option.

That's correct. It would be very useful to have that.

bryceitoc9 commented 2 years ago

@sboonyakiatACR

Just took a look, we should have disableRollback on the CloudFormation create/update stack task. Have you tried this, and if so, is this not meeting your current needs or expectations?

Slooz commented 1 year ago

@bryceitoc9 disableRollback exists as an input for the CloudFormationCreateOrUpdateStack task, but it doesn't do anything. The task never references or uses the input. It looks like the input was added, but the logic was never implemented.