aws / aws-toolkit-azure-devops

AWS Toolkit for Azure DevOps
Other
235 stars 100 forks source link

Update isNoWorkToDoValidationError to widen scope of error messages included #536

Open warren-burke84 opened 6 months ago

warren-burke84 commented 6 months ago

Description

There is a function that determines if an error occurred when processing a Cloudformation stack Create Or Update, it appears the at least one of the error messages returned by the AWS API have changed slightly and this update is to make a slight change to the known error messages validation to ensure that the updated error from AWS can be handled by this function.

The error message causing the issue is "CloudFormation failed to preprocess the stack: No updates are to be performed." the current code looks for errors starting with "No updates are to be performed." but it appears AWS has modified the error message to include the additional wording "CloudFormation failed to preprocess the stack: ".

Motivation

This issue currently breaks Azure DevOps pipelines that use the aws-toolkit to perform Cloudformation stack updates where no changes are to be applied, this sometimes happens when a pipeline is re-run using the same Cloudformation template. It has been fixed a couple of times in the past and this is a new iteration on that.

Related Issue(s), If Filed

No related issues.

Testing

Changes tested locally to verify the update works as expected.

Checklist

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.