aws / aws-toolkit-azure-devops

AWS Toolkit for Azure DevOps
Other
250 stars 106 forks source link

ECRPushImage warning in Azure Devops due to Node10 dependency #566

Open ganeshranfignum opened 2 months ago

ganeshranfignum commented 2 months ago

The ECRPushImage Task uses Node10 which is no longer supported . This causes a warning to be displayed on our build process in Azure Devops

##[warning]Task 'Amazon ECR Push' version 1 (ECRPushImage@1) is dependent on a Node version (10) that is end-of-life. Contact the extension owner for an updated version of the task. Task maintainers should review Node upgrade guidance: https://aka.ms/node-runner-guidance

jbstans commented 2 months ago

This isn't just limited to ECR - we're getting the same on AWSShellScript:

##[warning]Task 'AWS Shell Script' version 1 (AWSShellScript@1) is dependent on a Node version (10) that is end-of-life. Contact the extension owner for an updated version of the task. Task maintainers should review Node upgrade guidance: https://aka.ms/node-runner-guidance

I suspect the whole toolkit needs a v2 with a node update.

mhvelplund commented 3 weeks ago

AWS support ADO seems pretty dead. I wish I was stuck with ADO either :/

mhvelplund commented 3 weeks ago

I found out why they don't just bump the Node version. From PR #560:

Supporting node 16 requires bumping azure-pipelines-task-lib. We are currently blocked from doing this because this version bump uses a newer version of shelljs as a dependency, which produces runtime errors for our task. (see PR description in https://github.com/aws/aws-toolkit-azure-devops/pull/539 for more details).

decampo04 commented 3 weeks ago

Just to add, also seeing this on SystemsManagerGetParameter@1 task too:

##[warning]Task 'AWS SSM Get Parameter' version 1 (SystemsManagerGetParameter@1) is dependent on a Node version (10) that is end-of-life. Contact the extension owner for an updated version of the task. Task maintainers should review Node upgrade guidance: https://aka.ms/node-runner-guidance

seanezell commented 3 weeks ago

Just to add to the pile, we are seeing this on S3Upload, AWSShellScript.

We are also seeing the same on Terraform and Terraform-outputs. Different extensions, but the same issue.

JeroenBodeTriple commented 2 weeks ago

Same issue here for the AWSCLI, AWSShellScript, LambdaDeployFunction and ECRPushImage on our end. My guess is all the tasks for the aws-toolkit-azure-devops are affected by this.

symnatbay commented 2 weeks ago

Seeing the same over in our org. No new information, just leaving this comment to help express the potential impact of this deprecation.

sameerahmed720 commented 2 weeks ago

Its a on going issue with AWS and Terraform , fixed terraform issue by upgrading its version But AWSShellScript , AWSCLI issue is consistent even after version upgrade

isarastov commented 2 weeks ago

I'm seeing the same for S3Upload@1, SendMessage@1

tayalnishu commented 2 weeks ago

+1. Getting the same error for all tasks used from aws-toolkit-azure-devops. Would be good to know the timeline when it is expected to be upgraded.

ashokm commented 2 weeks ago

See https://github.com/jfrog/jfrog-azure-devops-extension/pull/518 for inspiration on addressing the issue. This seems to have worked for the JFrog marketplace extension, and the warning is no longer appearing.

rynop commented 2 weeks ago

Anyone have an official Microsoft doc that states when they are pulling the plug on node v10?

I opened an AWS support ticket and I can tell you AWS is aware of this.

saurabhajmera commented 2 weeks ago

I like to acknowledge that we are aware of this problem. In our past attempts to address this, we got blocked by a shelljs related JS bundler issue which prevented us from updating azure-pipelines-task-lib. We are looking into this again and will post an update once we have more information.

adurangalvis commented 2 weeks ago

I like to acknowledge that we are aware of this problem. In our past attempts to address this, we got blocked by a shelljs related JS bundler issue which prevented us from updating azure-pipelines-task-lib. We are looking into this again and will post an update once we have more information.

Is there a timeline when this is planned to be resolved?

saurabhajmera commented 2 weeks ago

Is there a timeline when this is planned to be resolved?

Not yet, but we will share more information once we have an update. Thank you for your patience.