aws / aws-toolkit-azure-devops

AWS Toolkit for Azure DevOps
Other
249 stars 106 forks source link

feat(node): support node 20 in tasks #581

Open hayemaxi opened 4 days ago

hayemaxi commented 4 days ago

Use Node 20 using microsoft guidance: https://learn.microsoft.com/en-us/azure/devops/extend/develop/add-build-task?view=azure-devops#q-how-can-i-upgrade-my-custom-task-to-the-latest-node

Keep Node 10 as a fallback.

Adding support requires a hacky patch to fix shell.js, which doesn't support bundlers. Mitigates the issue described in https://github.com/aws/aws-toolkit-azure-devops/pull/539

Addresses https://github.com/aws/aws-toolkit-azure-devops/issues/566

Credit to ivanduplenskikh: https://github.com/ivanduplenskikh/aws-toolkit-azure-devops/pull/1

Checklist

License

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

venugopal508 commented 23 hours ago

@hayemaxi please review this PR and merge...

we are waiting for these changes merged and for the new release...

so that we can avoid the warning Awsshellscriot@1 support node 10 end of life