Amazon Q Feature - Use language level from project and module settings

damntrecky commented 1 month ago

Types of changes

[ x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Description

The goal of this PR is to allow project validation to read the project and module level "language level" to help determine what Java version is being used.

IntelliJ references Maven <properties> and sets the appropriate "language level" at the project and module level.

  <properties>
    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
    <java.version>8</java.version>
    <maven.compiler.release>8</maven.compiler.release>
    <maven.compiler.source>1.8</maven.compiler.source>
    <maven.compiler.target>1.8</maven.compiler.target>
  </properties>

Will set "language level" to 8 in your module.

Impact

This will impact users who cannot transform because their JDK/SDK version is set to JDK 17 or higher. We will allow users who are compiling Java 8/11 projects from JDK 17+.

Previously if users had sdk set to JDK17 they automatically failed clientside validation and the project could not be submitted. We believe this will be a substantial change to help transform projects

Checklist

[x ] My code follows the code style of this project
[x ] I have added tests to cover my changes
[ ] A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
[ ] I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

damntrecky commented 1 month ago

rli commented 3 weeks ago

i don't think 232 understands that JDK21 exists

e: file:///codebuild/output/src3285644532/src/github.com/aws/aws-toolkit-jetbrains/plugins/amazonq/codetransform/jetbrains-community/tst/software/aws/toolkits/jetbrains/services/codemodernizer/utils/CodeTransformProjectUtilsTest.kt:11:48 Unresolved reference: getMockJdk21
e: file:///codebuild/output/src3285644532/src/github.com/aws/aws-toolkit-jetbrains/plugins/amazonq/codetransform/jetbrains-community/tst/software/aws/toolkits/jetbrains/services/codemodernizer/utils/CodeTransformProjectUtilsTest.kt:28:19 Unresolved reference: getMockJdk21