Closed arangatang closed 2 weeks ago
Before reauth
After reauth
Before clicking view diff
after being AFK for 15 min (Idc session duration set to 15 min)
Immediatelly when clicking view diff with expired credentials
When reauthenticated successfully transformation is resumed
When transformation resumed customers have a chance to redownload the results
Download then succeeds properly since credentials are updated
Issues
10 New issues
0 Accepted issues
Measures
0 Security Hotspots
No data about Coverage
0.7% Duplication on New Code
Failing test is:
software.aws.toolkits.jetbrains.services.lambda.dotnet.LambdaGutterMarkHighlightingTest
Which is unrelated to my changes.
changelog?
Types of changes
Description
~11% of API failures in May are due to expired credentials being used (InvalidGrantException). The most common places in the code where this happens is when users are about to upload their code or when about to download the code. This is due to at these points customers may have been inactive for a substantial amount of time (>15 min) either due to long running
mvn
builds or due to being afk before downloading results.This PR fixes this by forcing a refresh through chat when token is marked as NEED_REFRESH or if we get a SssOidcException. Additionally in the case of downloading an archive we need to resume the job after credential refresh such that users can reattempt the download. Detailed flow for the two cases detailed below:
Flow when token expired when calling CreateUpload:
Flow when token expired before calling ExportResultArchive
Misc changes (bugfixes / supporting changes)
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.