aws / aws-toolkit-jetbrains

AWS Toolkit for JetBrains - a plugin for interacting with AWS from JetBrains IDEs
https://plugins.jetbrains.com/plugin/11349-aws-toolkit
Apache License 2.0
749 stars 216 forks source link

refactor webview auth default region setting, move from LastLoginIdclnfo constructor to callee(webview browsers) #4577

Closed Will-ShaoHua closed 3 months ago

Will-ShaoHua commented 3 months ago

As a new ToolkitAuthManagerState will be created every few mins by the IDE to sync, thus the same warning log entry will pop up accordingly and spam the log file

data class ToolkitAuthManagerState(
    // TODO: can't figure out how to make deserializer work with polymorphic types
    var ssoProfiles: List<ManagedSsoProfile> = emptyList(),
    var lastLoginIdcInfo: LastLoginIdcInfo = LastLoginIdcInfo()
)

data class LastLoginIdcInfo(
    var profileName: String = "",
    var startUrl: String = "",
    var region: String = AwsRegionProvider.getInstance().defaultRegion().id
)

image

Types of changes

Description

Checklist

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

Will-ShaoHua commented 3 months ago

not clean (duplicate code) but there is one WIP webview refactor PR #4405

Will-ShaoHua commented 3 months ago

/retryBuilds

Will-ShaoHua commented 3 months ago

flaky test failing in windows 232 will be fixed in #4580

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.7% Duplication on New Code

See analysis details on SonarCloud