Send addConnection telemetry on builder id login - Githubissues

aws / aws-toolkit-jetbrains

AWS Toolkit for JetBrains - a plugin for interacting with AWS from JetBrains IDEs

https://plugins.jetbrains.com/plugin/11349-aws-toolkit

Apache License 2.0

749 stars 216 forks source link

Send addConnection telemetry on builder id login #4579

Closed wularr closed 3 months ago

wularr commented 3 months ago

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Description

Send addConnection telemetry on builder id login
Send loginWithBrowser failure only if builder id login failed

Checklist

[X] My code follows the code style of this project
[ ] I have added tests to cover my changes
[ ] A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
[X] I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

wularr commented 3 months ago

/runIntegrationTests

wularr commented 3 months ago

/runUnitTests

wularr commented 3 months ago

/retryBuilds

wularr commented 3 months ago

/runIntegrationTests