refactor browser message passing - Githubissues

aws / aws-toolkit-jetbrains

AWS Toolkit for JetBrains - a plugin for interacting with AWS from JetBrains IDEs

https://plugins.jetbrains.com/plugin/11349-aws-toolkit

Apache License 2.0

730 stars 197 forks source link

refactor browser message passing #4594

Closed Will-ShaoHua closed 1 week ago

Will-ShaoHua commented 2 weeks ago

Functional testing

Q

AWS ID

https://github.com/aws/aws-toolkit-jetbrains/assets/96078566/95bfdd32-1721-40d7-b381-f3b557da67f8

IdC

https://github.com/aws/aws-toolkit-jetbrains/assets/96078566/8cac36d5-7289-408a-a014-b059a78f7e60

Existing connection

https://github.com/aws/aws-toolkit-jetbrains/assets/96078566/b8a6a91a-ea32-43a8-b8c0-d623a1f1cbca

Reauthenticate

https://github.com/aws/aws-toolkit-jetbrains/assets/96078566/c05b7b53-3f67-41f9-96ae-783b3604d9da

Signout

https://github.com/aws/aws-toolkit-jetbrains/assets/96078566/f6a05fea-616b-4518-b657-e016e73ef08a

Toolkit

AWS ID

https://github.com/aws/aws-toolkit-jetbrains/assets/96078566/1b4c1dbd-e89a-4198-8d09-40b984664ceb

IdC

https://github.com/aws/aws-toolkit-jetbrains/assets/96078566/31b6bca8-7a3f-43a7-ba7b-70740cbfb33b

Existing connection

https://github.com/aws/aws-toolkit-jetbrains/assets/96078566/cf37c6b7-7f3a-4c8a-ac04-89381c7f68ce

Reauthenticate

https://github.com/aws/aws-toolkit-jetbrains/assets/96078566/197d369a-3af9-4c59-acd5-bc64757b0d7d

Signout

https://github.com/aws/aws-toolkit-jetbrains/assets/96078566/f5d193e9-995f-4336-94a2-80dbb759d9d6

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Refactor

Description

split of #4405 typesafe json message sent from JCEF browser

to address tech debt comments left since 4/30 https://github.com/aws/aws-toolkit-jetbrains/pull/4265/files#r1568361295

Checklist

[ ] My code follows the code style of this project
[ ] I have added tests to cover my changes
[ ] A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
[ ] I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

Will-ShaoHua commented 2 weeks ago

will upload functional test screen recording

Will-ShaoHua commented 1 week ago

/retryBuilds

Will-ShaoHua commented 1 week ago

/retryBuilds