fix cancellation exception gets swallowed - Githubissues

aws / aws-toolkit-jetbrains

AWS Toolkit for JetBrains - a plugin for interacting with AWS from JetBrains IDEs

https://plugins.jetbrains.com/plugin/11349-aws-toolkit

Apache License 2.0

730 stars 197 forks source link

fix cancellation exception gets swallowed #4607

Closed Will-ShaoHua closed 1 week ago

Will-ShaoHua commented 1 week ago

patch #4591 error is swallowed and not surface to UI components

Bug

chat UI should not be displayed is users cancel the login

https://github.com/aws/aws-toolkit-jetbrains/assets/96078566/254d5b5b-33f0-4f9b-baf6-f97c86515b52

Expected

https://github.com/aws/aws-toolkit-jetbrains/assets/96078566/7789c8c3-37d2-40df-8814-1e84dd342b86

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Description

Checklist

[ ] My code follows the code style of this project
[ ] I have added tests to cover my changes
[ ] A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
[ ] I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.