Take AWS error message only if details exists in refreshToken failure - Githubissues

aws / aws-toolkit-jetbrains

AWS Toolkit for JetBrains - a plugin for interacting with AWS from JetBrains IDEs

https://plugins.jetbrains.com/plugin/11349-aws-toolkit

Apache License 2.0

730 stars 197 forks source link

Take AWS error message only if details exists in refreshToken failure #4611

Closed wularr closed 1 week ago

wularr commented 1 week ago

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Description

This line: https://github.com/aws/aws-toolkit-jetbrains/blob/main/plugins/core/jetbrains-community/src/software/aws/toolkits/jetbrains/core/credentials/sso/SsoAccessTokenProvider.kt#L409 could fail if e.awsErrorDetails() returns null. Kotlin can't catch the typing error because AwsServiceException is defined in java.

https://github.com/aws/aws-toolkit-jetbrains/issues/4609 https://github.com/aws/aws-toolkit-jetbrains/issues/4610

Checklist

[X] My code follows the code style of this project
[X] I have added tests to cover my changes
[X] A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
[ ] I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

wularr commented 1 week ago

/retryBuild

sonarcloud[bot] commented 1 week ago

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud