Fix duplicated IdC failure metrics

Types of changes

[X] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)

Description

Currently, attempting to sign in through the Q by clicking "Use with Pro License" then cancelling results in duplicate browser login and addConnection metrics. This is because we are submitting metrics in the IdC-specific login function and in the general login function (the IdC-specific login function calls the general one).

This change will move all metrics decisions to the IdC-specific login function. The general login function does the actual submission through a hook.

Checklist

[X] My code follows the code style of this project
[ ] I have added tests to cover my changes
[ ] A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
[X] I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

aws / aws-toolkit-jetbrains