Support for Codeartifact

aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources

https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode

Apache License 2.0

1.48k stars 413 forks source link

Support for Codeartifact #1514

Open aeb-dev opened 3 years ago

aeb-dev commented 3 years ago

Is your feature request related to a problem? Please describe.

In order to list the nuget packages on Codeartifact, I have to manually run aws cli command to see my packages. Visual Studio AWS Toolkit can list the packages, so it would be good to have the same functionality on VSCode as well.

Describe the solution you'd like

I would like to see my packages on AWS:Explorer, preferably under Codeartifact label.

NickHeap2 commented 1 year ago

@aeb-dev I've started working on this and have the basics up already over here https://github.com/NickHeap2/aws-toolkit-vscode/tree/feature/codeartifact

NickHeap2 commented 1 year ago

@justinmk3 At Advanced we just need to be able to view the package versions using locked down read-only credentials. Can I implement this as just a view or would you need full integration for creating/deleting etc to accept it?

NickHeap2 commented 1 year ago

Looks like this so far

JadenSimon commented 1 year ago

@NickHeap2

Looking good so far! Could you open a PR with your changes so we can review and iterate on them?

I'd also convert your explorer implementations to use a new pattern we just added to increase consistency with things like pagination. ECS is currently the only integration using this pattern. Examples:

Apologies for having you do these changes, they were just recently merged.

Can I implement this as just a view or would you need full integration for creating/deleting etc to accept it?

We are still thinking about the scope of the integration but we don't think a create action is needed here, though a delete could be a nice-to-have. I'd leave it as a view-only for now of course. If you have any opinions on useful actions that should be included, definitely mention them in the PR description.

NickHeap2 commented 1 year ago

@JadenSimon Yes no problem I'll get on converting it when I get a chance. Our use cases are very simple as our access is read-only:

did my new package version get published correctly
what is the latest version of this package I'm using

So yes sticking with view-only is all we are going to need.

NickHeap2 commented 1 year ago

@JadenSimon I've updated my master to the new style. Will sort out the PR tomorrow.