aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources
https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode
Apache License 2.0
1.5k stars 424 forks source link

Filepath for download in output incorrect on Remote machines #2021

Open zb3qk opened 3 years ago

zb3qk commented 3 years ago

Describe the bug

When using the Remote SSH extension for VSCode in tandem with AWS Toolkit the file path outputted in the Output console when downloading a file from S3 does not match the actual path of the downloaded file. The file path outputted points to a file on the local machine when it instead should point to the file on the remote machine.

To Reproduce

Steps to reproduce the behavior:

  1. SSH onto a remote machine using the Remote SSH extension
  2. Download a file from S3
  3. Command click on the file path written in the AWS Toolkit Output window
  4. File cannot be found

Expected behavior

The file path written in the output console should point to the file saved in the remote machine, not a file that does not exist on the local machine.

Screenshots Copied from Console Downloading 0029a9b9-6dd1-49eb-81f9-3b15174681b2... Successfully downloaded file file:///tmp/0029a9b9-6dd1-49eb-81f9-3b15174681b2

Desktop (please complete the following information):

bryceitoc9 commented 3 years ago

A couple questions:

JadenSimon commented 3 years ago

By default, links with the scheme file: will point to the local file system. This behavior appears to be intended by VS Code. So the toolkit should instead register a link provider for the output channel to correctly resolve the links to wherever the extension is running.