aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources
https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode
Apache License 2.0
1.46k stars 408 forks source link

Lambda Layer support #3336

Open niradler opened 1 year ago

niradler commented 1 year ago

Problem

we love the Lambda download/upload feature (filter and pagination are very needed)

Expected behavior

we want the same functionality for layers, download a version/publish the new version

The Toolkit is great Thanks for this 🥇

justinmk3 commented 1 year ago

Thanks for the feedback! Filtering/grouping is something that is high on our priority list.

we want the same functionality for layers

Have you tried Lambda with packagetype=image ? https://docs.aws.amazon.com/lambda/latest/dg/images-create.html This allows you to define a Dockerfile that defines your Lambda environment.

This essentially replaces Lambda "layers", so we don't have plans to add explicit support for layers to AWS Toolkit.

niradler commented 1 year ago

@justinmk3 Thanks for the response, I'm familiar with custom images, but we don't use them at the moment, we are not sure about cold start impact and this only helps for shared dependencies and is less effective for the more unique use cases, at least in my mind, but I will revisit this if we will contribute layers support will this be accepted?

justinmk3 commented 1 year ago

if we will contribute layers support will this be accepted?

Yes, contributions are very welcome.