search

aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources
https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode
Apache License 2.0
1.47k stars 408 forks source link

CodeWhisperer: setting disabled per user, but per workspace shows enabled #3477

Closed ezekiel747 closed 1 year ago

ezekiel747 commented 1 year ago

Problem

I uncheck the option "Code Whisperer: Share Code Whisperer Content With AWS" from extension settings, at the user level, but when showing settings at workspace level it's checked, even though nothing specific is actually in the workspace settings file.

Steps to reproduce the issue

  1. Go to extensions, click on settings icon, select Extension settings
  2. Select the User tab (not workspace)
  3. Uncheck "Code Whisperer: Share Code Whisperer Content With AWS"
  4. Select the Workspace tab
  5. Notice "Code Whisperer: Share Code Whisperer Content With AWS" is checked
  6. Open the settings json file in workspace
  7. Notice it doesn't have any value to override the User setting.

Expected behavior

This should show up as unchecked as per User settings, if not otherwise overriden with a different value in the workspace settings.

System details (run the AWS: About Toolkit command)

justinmk3 commented 1 year ago

This might be just a vscode UI quirk. The user-global "disabled" setting should apply to the workspace, even if vscode shows the workspace-local setting as "enabled".

https://code.visualstudio.com/docs/getstarted/settings#_settings-precedence doesn't make this clear.

We are looking for a way to make this clearer.

justinmk3 commented 1 year ago

This should be fixed in AWS Toolkit 1.82