aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources
https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode
Apache License 2.0
1.49k stars 418 forks source link

fix(build): package task fails if commit id starts with zero #5118

Closed justinmk3 closed 3 months ago

justinmk3 commented 3 months ago

Problem:

package task fails if commit id starts with zero.

ERROR  Invalid extension version '3.9.0-0238109'

semver disallows leading zero for prerelease. This is why git describe always adds a "g" prefix, for example.

Solution:

Prefix the prerelease string with "g", similar to git describe.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.