aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources
https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode
Apache License 2.0
1.49k stars 418 forks source link

feature: reduce complexity of extensionCommon activation #5127

Closed 32teeth closed 3 months ago

32teeth commented 3 months ago

Problem

The original activateAmazonQCommon function in the Amazon Q VS Code extension had a high complexity, making it difficult to maintain and understand.

Solution

The function was refactored to reduce complexity by breaking it down into smaller, single-responsibility functions. The refactoring included:

License

32teeth commented 3 months ago

[!WARNING] CI / test macOS (16.x, minimum) (pull_request) delta

When running the PR on my own fork, all tests pass (this is done to ensure prior to submitting PR to main that fork is good)

justinmk3 wondering if you have any insights?

[!NOTE] Screenshots

main fork
Screenshot 2024-06-11 at 11 51 15 AM Screenshot 2024-06-11 at 11 51 05 AM