fix(security scan): scan during user input causes slow performance

laileni-aws commented 3 months ago

Problem

VSC triggers getDirSize() function to calculate codeScanProjectBytes for telemetry for both Auto-scans and Project scans.

Solution
Disable the codeScanProjectBytes calculation for Auto-scans: Since the codeScanProjectBytes parameter is optional for Auto-scans and is affecting the performance, it makes sense to disable the calculation for this scenario. This will help improve the overall performance of the Auto-scans.
Enable the codeScanProjectBytes calculation for Project scans: For Project scans, you should continue to calculate the codeScanProjectBytes using the getDirSize() function, as this information is likely valuable for the telemetry.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

leigaol commented 3 months ago

In the PR statement, please elaborate on a bit laggy of getDirSize.

Run it in a repository of 1k files with 10 to 20 folder levels, explain the exact time it takes to run. Do this experiment to quantify the impact.

leigaol commented 3 months ago

Can you rename this PR ?

leigaol commented 3 months ago

I can approve once you add a change log item