fix(codecatalyst): always send heartbeat activity - Githubissues

aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources

https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode

Apache License 2.0

1.49k stars 418 forks source link

fix(codecatalyst): always send heartbeat activity #5130

Closed justinmk3 closed 3 months ago

justinmk3 commented 3 months ago

Problem

Toolkit requires a connection / auth session token to send heartbeat activity: https://github.com/aws/aws-toolkit-vscode/blob/4512e2052ec29bed0b11184e606b3937daa99346/packages/core/src/codecatalyst/devEnv.ts#L73-L94 This means if the user is not connected, the dev env will time out.

Solution

Always send heartbeat activity (except when we know that inactivityTimeoutMinutes=0).
If inactivityTimeoutMinutes is unknown, assume it is 15 minutes.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

justinmk3 commented 3 months ago

/runintegrationtests ..