aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources
https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode
Apache License 2.0
1.49k stars 418 forks source link

fix(dev mode): startup fails on invalid dev.logfile #5146

Closed justinmk3 closed 3 months ago

justinmk3 commented 3 months ago

Problem: Extension fails to start if the "aws.dev.logfile" setting returns nonsense. settings.getSection().get() is a very thin wrapper around vscode.workspace.getConfiguration(), so it doesn't have the type checking and coercion of the Settings class.

Solution: Check the type.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.