search

aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources
https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode
Apache License 2.0
1.49k stars 418 forks source link

chore: upgrade codewhisperer-streaming client #5147

Closed JuliaABurch closed 3 months ago

JuliaABurch commented 3 months ago

Problem

The streaming client needs to be updated to access recent API changes.

Solution

I followed the instructions here to regenerate the client source files. I ran a quick test of basic chat features (Q, Featuredev, Gumby) to ensure stability.

Note: the client is 2 months out of date at this point, so quite a few changes have been generated.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

justinmk3 commented 3 months ago

1 million added lines and almost no deletions seems wrong.

Probably the first step, is to delete the existing directory and replace it with the new generated result. That should result in a much more reasonable diff.

If that's not mentioned in the instructions, please update the instructions.

justinmk3 commented 3 months ago

If the dist-* dirs are committed, then there is no need for the typescript files at all. We should choose one or the other.

Why is the node_modules tree part of this PR? The current situation is that this sub-project has a package.json , and those deps are fetched at build-time. So adding node_modules to the repo bloats the size of the repo and will cause churn.

justinmk3 commented 3 months ago

/runintegrationtests

JuliaABurch commented 3 months ago

1 million added lines and almost no deletions seems wrong.

Probably the first step, is to delete the existing directory and replace it with the new generated result. That should result in a much more reasonable diff.

If that's not mentioned in the instructions, please update the instructions.

I've updated the instructions with some error handling so that the clean / deletion happens much more reliably.