[split sessions] feat(auth): update api for split sessions

aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources

https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode

Apache License 2.0

1.49k stars 418 forks source link

[split sessions] feat(auth): update api for split sessions #5150

Closed hayemaxi closed 3 months ago

hayemaxi commented 3 months ago

Separate sessions commit

Add new API to Toolkit to "declare" and "undeclare" a connection. Unlike the other API methods, this will inform the toolkit of existing connections without accepting them into its auth environment. This allows it to use params from other connections, e.g. start url region. It does not persist.
Retain original API because it may be beneficial in the future for other extensions/use cases
Change Amazon Q's usage of the API to declare instead of direct session sharing.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

nkomonen-amazon commented 3 months ago

What I gather from this PR is that Amazon Q can look at the connections from Toolkits, and use their metadata to create a separate connection for itself? Does this mean that the webview which shows being able to "reuse" an existing connection will still remain, but if they select that we will create a new connection instead of adding scopes to it?

hayemaxi commented 3 months ago

What I gather from this PR is that Amazon Q can look at the connections from Toolkits, and use their metadata to create a separate connection for itself? Does this mean that the webview which shows being able to "reuse" an existing connection will still remain, but if they select that we will create a new connection instead of adding scopes to it?

That's correct. The implementation for that will be in the next PR.