feature: replace lodash dependencies with native

aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources

https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode

Apache License 2.0

1.42k stars 357 forks source link

feature: replace lodash dependencies with native #5157

Closed 32teeth closed 2 weeks ago

32teeth commented 1 month ago

Problem

most of the used lodash features can be replaced with modern JavaScript

Solution

removed lodash from dependencies npm uninstall @types/lodash lodash
_.cloneDeep replaced with _CloneDeep
_.set replaced with _Set
_.get replaced with _Get
_.isEmpty replaced with _IsEmpty

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

justinmk3 commented 3 weeks ago

Thanks for looking into this! We have a backlog issue that proposed this.

For debounce/throttle, maybe it makes sense to only depend on those specific lodash packages? That would avoid accidental and presumably unnecessary use of most other lodash features.

removed lodash from dependencies npm uninstall @types/lodash lodash

forgot --save ? :)