fix(telemetry): set UserAgent in Q, OIDC/SSO requests - Githubissues

aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources

https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode

Apache License 2.0

1.49k stars 418 forks source link

fix(telemetry): set UserAgent in Q, OIDC/SSO requests #5158

Closed justinmk3 closed 3 months ago

justinmk3 commented 3 months ago

Problem

missing user agent, clientid, requestid for failed OIDC and Amazon Q requests.

Solution

set customUserAgent in the SSO and OIDC clients
set customUserAgent in the CodeWhispererStreaming (Amazon Q) client
set requestId and reasonDesc on all failed metrics

Example headers:

user-agent: aws-sdk-js/3.574.0 ua/2.0 os/darwin#23.5.0 lang/js md/nodejs#20.9.0 api/sso-oidc#3.574.0 AmazonQ-For-VSCode/testPluginVersion-Visual-Studio-Code/1.90.1-ClientId/96be923b-a00d-46d4-add1-c877abfcb01c
x-amz-user-agent: aws-sdk-js/3.574.0 AmazonQ-For-VSCode/testPluginVersion-Visual-Studio-Code/1.90.1-ClientId/96be923b-a00d-46d4-add1-c877abfcb01c

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.