fix(amazonq): filesystem errors are not surfaced - Githubissues

aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources

https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode

Apache License 2.0

1.41k stars 349 forks source link

fix(amazonq): filesystem errors are not surfaced #5181

Closed justinmk3 closed 2 weeks ago

justinmk3 commented 2 weeks ago

Problem

amazonq main does not use activateCommon, so it is missing some common logic.
- does not define a handler for bubbled-up errors, so errors are not displayed in a user-facing message.
findBestErrorInChain() discards non-AWSError, so filesystem errors are not surfaced.

Solution

call registerCommandErrorHandler in amazonq init.
- TODO: can amazonq init share common init w/ toolkit?
improve findBestErrorInChain() so that it finds filesystem errors.

Examples

windows:
macos:

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.