aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources
https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode
Apache License 2.0
1.41k stars 349 forks source link

[split sessions] fix(auth): login page displays connections that already exist #5186

Closed hayemaxi closed 2 weeks ago

hayemaxi commented 2 weeks ago

Problem: We do not allow the SSO form to continue if the user tries putting in an IdC start url that already exists in the same extension. However, this check isn't in place for displaying connections from the other extension. This means users can duplicate the connection start url in the extension and caused undefined behavior.

Solution: Filter out existing connections from other extensions on what connections are in the current extension.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.