aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources
https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode
Apache License 2.0
1.41k stars 349 forks source link

StepFunctions: ASL / state machine language LSP server crashing on 3.10.0 (but not 3.9.0) #5195

Closed justinmk3 closed 1 week ago

justinmk3 commented 2 weeks ago

from @up-town-down in https://www.github.com/aws/aws-toolkit-vscode/issues/5151#issuecomment-2180658276 :

I'm seeing an error with the the state machine language server, but it's on 3.10.0 and is not occurring in 3.9.0 Screenshot 2024-06-20 at 14 11 28 log attached toolkit.log

Node.js v20.9.0
[Info  - 14:08:16] Connection to server got closed. Server will restart.
node:internal/modules/cjs/loader:1058
  throw err;
  ^

Error: Cannot find module 'vscode'
Require stack:
- /Users/user/.vscode/extensions/amazonwebservices.aws-toolkit-vscode-3.10.0/dist/src/stepFunctions/asl/aslServer.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1055:15)
    at Module._load (node:internal/modules/cjs/loader:908:27)
    at c._load (node:electron/js2c/node_init:2:13672)
    at Module.require (node:internal/modules/cjs/loader:1122:19)
    at require (node:internal/modules/helpers:130:18)
    at /Users/user/.vscode/extensions/amazonwebservices.aws-toolkit-vscode-3.10.0/dist/src/stepFunctions/asl/aslServer.js:1393:72630
    at /Users/user/.vscode/extensions/amazonwebservices.aws-toolkit-vscode-3.10.0/dist/src/stepFunctions/asl/aslServer.js:1394:7362
    at Object.<anonymous> (/Users/user/.vscode/extensions/amazonwebservices.aws-toolkit-vscode-3.10.0/dist/src/stepFunctions/asl/aslServer.js:1394:7401)
    at Module._compile (node:internal/modules/cjs/loader:1256:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1311:10) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    '/Users/user/.vscode/extensions/amazonwebservices.aws-toolkit-vscode-3.10.0/dist/src/stepFunctions/asl/aslServer.js'
  ]
}
aldoromo88 commented 1 week ago

still happening on aws-toolkit-vscode-3.11.0

justinmk3 commented 1 week ago

We are working on this. https://github.com/aws/aws-toolkit-vscode/pull/5226

justinmk3 commented 1 week ago

Fixed in AWS Toolkit 3.12.0. We have test coverage to prevent this issue in the future.

up-town-down commented 5 days ago

Confirmed - seeing this as working now - thanks @justinmk3