aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources
https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode
Apache License 2.0
1.41k stars 346 forks source link

fix: added branch main to yml files because new forking styles #5214

Closed 32teeth closed 1 week ago

32teeth commented 1 week ago

Problem

GitHub changed it's naming many years ago. As should we.

Solution

Added main where needed in workflows

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

32teeth commented 1 week ago

Wondering how yml change impacts Linux build?

Build Name
Linux Unit Tests - minimum

maybe flaky retries on with assertion?

justinmk3 commented 1 week ago

the failing promptForConnection test is a known issue https://github.com/aws/aws-toolkit-vscode/issues/5115

justinmk3 commented 1 week ago

is this for forks?

if/when this repo changes its default branch, then it would make sense to replace 'master' with 'main'. until then, what is the purpose of adding || 'main' to various conditions?