Closed JuliaABurch closed 5 days ago
Note: in adding test coverage, I brought the test from the
amazonq
package to thecore
package, as it tests the internals of thetransformApiHandler
class, which lives in thecore
package.
Thanks for mentioning that. Can that be avoided? This is reversing the direction we want to go.
For example, try exporting from one of the index.ts files, e.g. https://github.com/aws/aws-toolkit-vscode/blob/f1ba3d1e0e48bb169e15dc7bf065c1518626423c/packages/core/src/amazonqFeatureDev/index.ts#L6-L10
Problem
Some gumby workflows need a specific artifact ID, but if one is not defined, we expect
exportContext
to not be definedSolution
This change uses nullish coalition to optinally add the
exportContext
property whendownloadArtifactId
is defined.Note: in adding test coverage, I brought the test from the
amazonq
package to thecore
package, as it tests the internals of thetransformApiHandler
class, which lives in thecore
package.Testing done
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.