fix(featureDev): progress UX during backend calls

aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources

https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode

Apache License 2.0

1.41k stars 346 forks source link

fix(featureDev): progress UX during backend calls #5223

Closed kumsmrit closed 1 week ago

kumsmrit commented 1 week ago

Problem

There was some mynah update which caused the in progress message to be hidden leading to bad experience for customers as they would not be aware that their calls are in progress.

Screenshot 2024-06-24 at 10 30 02

Solution

Mynah changes were fixed with this PR: https://github.com/aws/mynah-ui/pull/67
Bumped mynah-version to use latest fix

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

dogusata commented 1 week ago

This version update of mynah-ui also contains following fixes

Authenticate button and suggested follow up answer is expected to be rendered as button in the Chat UI, instead they are appearing inline as text
Clicking a different button (i.e. "Explain Selected Code") before the "Authenticate" button appears will show the Authenticate button along with "Generating answer prompt". This "Generating answer" prompt will not disappear until the next user input
Scrolling through the User Input message textbox in the Chat UI doesn't scroll the text, it scrolls the additional UI
(non-blocking, nice to have) Some clipping on the left hand side when code is shown in the chat response. Toolkit does not control the rendering piece, so has to be handled MynahUI side
Generating your answer card appears right before the help message called from /help command.

justinmk3 commented 1 week ago

/retrybuild

jpinkney-aws commented 1 week ago

Should we be adding changelog items for these?

Authenticate button and suggested follow up answer is expected to be rendered as button in the Chat UI, instead they are appearing inline as text Clicking a different button (i.e. "Explain Selected Code") before the "Authenticate" button appears will show the Authenticate button along with "Generating answer prompt". This "Generating answer" prompt will not disappear until the next user input Scrolling through the User Input message textbox in the Chat UI doesn't scroll the text, it scrolls the additional UI (non-blocking, nice to have) Some clipping on the left hand side when code is shown in the chat response. Toolkit does not control the rendering piece, so has to be handled MynahUI side Generating your answer card appears right before the help message called from /help command.

Some of those seem very customer facing and would be good for users to know its fixed