fix: step function language server activation

[jpinkney-aws]

Problem

• step function language server failed to activate

Solution

• remove globals from the language server

Additional investigation

• Still investigating but it looks like something between version 2.20 and 3.0.0 broke the step functions language server activation. AFAICT the error occurs because the language server was starting in another process and that process doesn't have access to vscode which globals seems to be importing. It's not exactly clear why this is caused in 3.0.0 and not early though

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[justinmk3]

looks like something between version 2.20 and 3.0.0 broke the step functions language server activation

In https://github.com/aws/aws-toolkit-vscode/commit/fa54d7c0a07a4acb8675ffe89178a1c8c146cbd5 (April 2024) the globals check became more strict. In this case, it appears to have found a legitimate issue, but somehow the failing ASL server wasn't noticed in CI.

[VaidSaraswat]

Just to be clear, this will mean customers won't be able to see the error checking if they have an asl.json file open from a previous session. If they were to close the file and reopen it the language server starts (which is the behaviour I verified). I will be looking into the second issue reported where the server doesn't start from when a file is already opened.

[jpinkney-aws]

Just to be clear, this will mean customers won't be able to see the error checking if they have an asl.json file open from a previous session

I can't reproduce that anymore with this PR. This step functions activation issue has been present for ~2.5 months apparently so any step functions intellisense between toolkit 2.20.0 and now shouldn't have been working at all