search

aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources
https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode
Apache License 2.0
1.41k stars 346 forks source link

tests: skip promptForConnection on "min vscode" CI #5228

Closed justinmk3 closed 1 week ago

justinmk3 commented 1 week ago

Problem

Test constantly fails on "minimum vscode" CI job: https://github.com/aws/aws-toolkit-vscode/issues/5115

Auth
  promptForConnection
    reauthenticates a connection if the user selects an expired one:
 AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value:
 assert_1.default.ok(!refreshedConnItem.description?.match(/expired/i))
 + expected - actual

 -false
 +true
 at /codebuild/output/src3389505232/src/github.com/aws/aws-toolkit-vscode/packages/core/src/test/credentials/auth.test.ts:512:24
 at runMicrotasks (<anonymous>)
 at processTicksAndRejections (node:internal/process/task_queues:96:5)
 at async /codebuild/output/src3389505232/src/github.com/aws/aws-toolkit-vscode/packages/core/src/test/shared/vscode/window.ts:496:29

Solution

Skip the test on the "minimum vscode" CI job.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.