search

aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources
https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode
Apache License 2.0
1.41k stars 346 forks source link

fix: race condition in step functions language server activation test #5244

Closed jpinkney-aws closed 50 minutes ago

jpinkney-aws commented 6 days ago

Problem

Sometimes the language server can start and fire the onReady event before we are listening for it in the tests, causing the tests to never receive the event

Solution

Set isReady on the ASLLanguageClient class and wait for the client to be ready in the test

Alternative

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

jpinkney-aws commented 6 days ago

/runIntegrationTests

jpinkney-aws commented 6 days ago

/runIntegrationTests

justinmk3 commented 6 days ago

Is it only failing on "minimum"? We will bump our minimum required vscode pretty soon.

P.S. the failing InactivityMessages test is fixed here : https://github.com/aws/aws-toolkit-vscode/pull/5260

jpinkney-aws commented 6 days ago

Its failed on stable and insiders on master recently as well. Kinda weird because i'm seeing 100% success rate locally

jpinkney-aws commented 6 days ago

/runIntegrationTests

jpinkney-aws commented 1 day ago

/runIntegrationTests

justinmk3 commented 1 hour ago

Nice simplification.