aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources
https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode
Apache License 2.0
1.41k stars 346 forks source link

fix: handling validation errors in approach/code generation #5245

Open gasolima opened 6 days ago

gasolima commented 6 days ago

Problem

When a validation errors(repo size exceeds limit or corrupted zip file) thrown from approach/code generation it will show generic internal error to the user

Solution

Catch those errors and show proper errors

Screenshot 2024-06-28 at 08 44 13 Screenshot 2024-06-28 at 08 42 34

REMINDER:
- Read CONTRIBUTING.md first.
- Add test coverage for your changes.
- Update the changelog using `npm run newChange`.
- Link to related issues/commits.
- Testing: how did you test your changes?
- Screenshots (if the pull request is related to UI/UX then please include light and dark theme screenshots)

-->

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

justinmk3 commented 2 days ago

CI failing. Also needs a rebase.