aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources
https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode
Apache License 2.0
1.41k stars 346 forks source link

feat(amazonq-chat): customization support #5254

Open Will-ShaoHua opened 2 days ago

Will-ShaoHua commented 2 days ago

Problem

Chat API: generateAssistantResponse doesn't pass customizationArn(if there is one being used), this PR will

functional testing

UI: move select customization from "inline suggestion" to "others"

image

Pass customizationArn if applicable via API generateAssistantResponse

IDC with customization selected

https://github.com/aws/aws-toolkit-vscode/assets/96078566/7f9faf20-33c5-48e5-b7ee-0983c8204657

IDC without customization

https://github.com/aws/aws-toolkit-vscode/assets/96078566/303139ee-d822-40f1-952d-a97f2b4eca3b

Builder ID

https://github.com/aws/aws-toolkit-vscode/assets/96078566/bb6164a6-22a1-4ed3-bba1-066302bd5b22

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

justinmk3 commented 2 days ago

Does this have user-facing impact? E.g. are customizations used in more scenarios now, and if so, which ones? That is also something to mention in the Problem/Solution (which is not optional).

  1. Review the changelog guidelines.
  2. Add a new changelog entry: npm run newChange -w packages/amazonq or npm run newChange -w packages/toolkit
Will-ShaoHua commented 2 days ago

hey Justin, yea i'm aware of that, will update PR description and changelog later after discussing with the team

Will-ShaoHua commented 12 hours ago

@justinmk3 fyi, the team decided not to announce it via changelog in this PR as customization is not being used by the service at this point. And we will announce it in a followup PR where we will add service metric sending sendTelemetryEvent