Our fs.ts module does not have the advanced error-handling present in our SystemUtilities module.
fsCommon.delete() defaults to recursive:true, which means directories may be unintentionally deleted when a file was expected, and related errors are not surfaced.
Solution:
Merge the features of SystemUtilities into fs.ts.
Migrate SystemUtilities.delete().
Change fsCommon.delete() to default to recursive:false.
Update callers to explicitly pass recursive:true, where appropriate.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
justinmk3
commented
3 months ago
Note: This commit is part of a series.
Problem:
fs.tsmodule does not have the advanced error-handling present in ourSystemUtilitiesmodule.fsCommon.delete()defaults torecursive:true, which means directories may be unintentionally deleted when a file was expected, and related errors are not surfaced.Solution:
SystemUtilitiesintofs.ts.SystemUtilities.delete().fsCommon.delete()to default torecursive:false.recursive:true, where appropriate.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.