aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources
https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode
Apache License 2.0
1.47k stars 408 forks source link

refactor(fs): eliminate srcShared/ namespace #5274

Closed justinmk3 closed 2 months ago

justinmk3 commented 2 months ago

Problem

The srcShared/ concept is not necessary, and confusing to explain. Instead, a more tractable and less-churn approach is:

  1. Assume that ALL modules are "cross platform" (i.e. they support both nodejs and web-mode).
  2. Web-only logic lives in a fooWeb.ts module or a web/ directory relative to its namespace.
  3. Nodejs-only logic lives in a fooNodejs.ts module or a nodejs/ directory relative to its namespace.

See also:

Solution

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

justinmk3 commented 2 months ago

/runintegrationtests