feat: proactively show code generation iterations

aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources

https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode

Apache License 2.0

1.47k stars 408 forks source link

feat: proactively show code generation iterations #5282

Closed linyuxi0511 closed 2 months ago

linyuxi0511 commented 2 months ago

Problem

Currently, there is no information shown to customers in the chat regarding the number of iterations they could run during code generation. They only get to know this on hitting the iteration limits and seeing the error like you have reached the limit for number of iterations.

Solution

Hence, with this change, we are showing the remaining iterations proactively by exposing the remaining iteration numbers and total iteration numbers to the end of each code generation.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

linyuxi0511 commented 2 months ago

linyuxi0511 commented 2 months ago

Original task: https://taskei.amazon.dev/tasks/D138685414 Back-end changes are already in prod.

jeffpyj commented 2 months ago

CI / test Windows (16.x, stable) (pull_request) seems to be failing. Is that expected?

jpinkney-aws commented 2 months ago

This kind of feels like it should be inside of that diff view panel rather then a chat message that happens after. Was this reviewed by any UX designer?

linyuxi0511 commented 2 months ago

Yes this is reviewed with UX. Also this is considered to be a short-term solution as we are going to improve the UI/UX shotly.

linyuxi0511 commented 2 months ago

Confirmed with @jpinkney-aws that the tests are known to be flaky.