fix: refactor broke webview paths

aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources

https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode

Apache License 2.0

1.47k stars 409 forks source link

fix: refactor broke webview paths #5299

Closed nkomonen-amazon closed 2 months ago

nkomonen-amazon commented 2 months ago

Problem:

A recent refactor did not update certain static paths which prevent webviews from working.

Solution:

Fix the incorrect paths.

Testing it works

Create a REST API Gateway on my AWS account
In the AWS Explorer right click the REST API and select Invoke on AWS, this will open the webview.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

justinmk3 commented 2 months ago

What about this one: https://github.com/aws/aws-toolkit-vscode/blob/87a1b76f7b14ad1446edcc241fa5cca3b44d8b61/packages/core/src/codecatalyst/vue/configure/backend.ts#L33

and others?

nkomonen-amazon commented 2 months ago

The only paths impacts were the folders moved in to src/awsService. I haven't moved codecatalyst, q, and some other folders in to it so they are fine. We will probably not touch Q, and the remaining we will look at individually. @justinmk3