.eslintignore is mostly redundant with .gitignore and is missing something specified by .gitignore.
some prettier rules are not enforced by our eslint rules. For example, if a developer doesn't have prettier configured, they may commit files without EOL and this isn't caught by our lint CI.
Solution
use eslint --ignore-path .gitignore and remove .eslintignore
install eslint-plugin-prettier which automatically enforces prettier rules as eslint rules.
Note: the formatting changes are from arrowParens=always. See commit for details.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Problem
Solution
eslint --ignore-path .gitignore
and remove .eslintignoreeslint-plugin-prettier
which automatically enforces prettier rules as eslint rules.Note: the formatting changes are from
arrowParens=always
. See commit for details.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.