aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources
https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode
Apache License 2.0
1.47k stars 408 forks source link

test/CI performance: vscode downloaded multiple times #5311

Open justinmk3 opened 2 months ago

justinmk3 commented 2 months ago

Problem

Since we now run the tests in each package/x/ separately, vscode is downloaded redundantly in our tests:

Running unit test suite...
Setting up VS Code test instance, version: stable
Downloading VS Code 1.91.1 from https://update.code.visualstudio.com/1.91.1/darwin-arm64/stable
Downloading VS Code (130067222B)

This adds time to each CI run.

Proposal

vscode-test has a flag that allows pointing to a directory where it should be downloaded (or skipped if it already exists). Update our test runner script to specify a directory at the repo top level.