search

aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources
https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode
Apache License 2.0
1.47k stars 408 forks source link

ci: codecov "codewhisperer" coverage report is wrong #5312

Closed justinmk3 closed 1 month ago

justinmk3 commented 2 months ago

Problem

now that coverage is uploading, it looks like our codewhisperer coverage has decreased.

Possibly, since we moved the tests into packages/amazonq/, the lcov.info file is getting overwritten by the last test run?

Expected behavior

codecoverage for each package should be uploaded. Maybe this can be done by specifying an argument to c8, so that each package has a separate lcov file? https://github.com/aws/aws-toolkit-vscode/blob/eae810bf6dad43d4e43e80682ca978e063b5eefe/packages/amazonq/package.json#L62-L63

e.g. c8 --foo ../../lcov-amazonq.info

then in our codecov upload steps, we specify the three expected files:

lcov-amazonq.info
lcov-toolkit.info
lcov-core.info
jpinkney-aws commented 1 month ago

Closed by https://github.com/aws/aws-toolkit-vscode/pull/5334