search

aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources
https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode
Apache License 2.0
1.51k stars 436 forks source link

ignore #5520

Closed dhasani23 closed 2 months ago

dhasani23 commented 2 months ago

Problem

Update: getting confused about a couple of things so I'm going to move this to another PR once I understand what exactly needs to happen.

1) We decided to no longer emit frontend telemetry for API errors and latency and 2) I made some minor updates to the common telemetry package and so need to use those updated fields.

Solution

Remove unneeded emit calls and use updated fields.

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions[bot] commented 2 months ago

This pull request modifies files in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required.

github-actions[bot] commented 2 months ago

This pull request modifies a feature or fixes a bug, but it does not include a changelog entry. All pull requests that introduce new features or bug fixes must have a corresponding changelog item describing the changes.