aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources
https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode
Apache License 2.0
1.51k stars 436 forks source link

fix: Patch ux for sso start url login field #5529

Open apexDev37 opened 2 months ago

apexDev37 commented 2 months ago

Problem

The Start URL field in the Workforce (SSO) sign-in page provides a single error message when the user's input fails validation. Error message: URLs must start with http:// or https://. Example: https://d-xxxxxxxxxx.awsapps.com/start. In some cases, this error message can be misleading or a false positive where the user's input contains a valid protocol or scheme yet fails some other form of validation required for the Start URL field.

Use case

Users who copy or retrieve their start URL from the Get credentials for [SampleRole] in the AWS Access portal for a given IAM Identity Center user will notice their start URL, for example, https://d-xxxxxxxxxx.awsapps.com/start/#, fail validation and get the following error message displayed: URLs must start with http:// or https://. Example: https://d-xxxxxxxxxx.awsapps.com/start. By default, the start URL from the Get credentials for [SampleRole] window includes a trailing forward slash and hashtag, (/#).

ℹ This differs from the start URL copied from the IAM Identity Center user Console which does not end with a trailing forward slash / or hashtag #

Example

aws-sso-error

Solution

This PR closes the following corresponding issue.

Resolves: #5462

This PR introduces patches to enhance the UX for the Start URL login field:

Decisions

This section outlines notable considerations for developers/maintainers.


License

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions[bot] commented 2 months ago

This pull request modifies files in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required.

github-actions[bot] commented 2 months ago

This pull request modifies a feature or fixes a bug, but it does not include a changelog entry. All pull requests that introduce new features or bug fixes must have a corresponding changelog item describing the changes.