search

aws / aws-toolkit-vscode

Amazon Q, CodeCatalyst, Local Lambda debug, SAM/CFN syntax, ECS Terminal, AWS resources
https://marketplace.visualstudio.com/items?itemName=AmazonWebServices.amazon-q-vscode
Apache License 2.0
1.51k stars 436 forks source link

fix(amazonq): sign-in notification displaying if user is signed in #5544

Closed hayemaxi closed 2 months ago

hayemaxi commented 2 months ago

Problem: Start using Amazon Q can display if there is some error restoring the connection object in the main Auth class. May be a network error or some other error. This is fine because Q uses secondary auth, so it only needs to be restored in that class. However, the notification logic access is in the Auth class which may not be restored.

Solution: Use AuthUtil to check if there is a connection instead of Auth.

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions[bot] commented 2 months ago

This pull request modifies files in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required.